Skip to content

Add withdrawal operations #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 3, 2022
Merged

Add withdrawal operations #195

merged 11 commits into from
Nov 3, 2022

Conversation

@ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Mar 10, 2022

Adds support for withdrawals.

Part of the validator withdrawals feature tracking here: https://notes.ethereum.org/@ralexstokes/Skp1mPSb9

ralexstokes
ralexstokes commented Mar 10, 2022
View reviewed changes
@ralexstokes ralexstokes force-pushed the add-withdrawal-operations branch from da9df27 to 6a785aa Compare March 10, 2022 16:40
djrtwo
djrtwo reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. My main comment is to consider where this should live and how it be surfaced in the specs.

We also probably need a "meta" section mapping forks to a set of methods. That is, Bellatrix uses all V1, whereas Capella uses a mix.

I would definitely refrain from merging until the Merge dust is fully settled.

great work!

lightclient
lightclient reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general to me.

mkalinin
mkalinin reviewed Mar 17, 2022
View reviewed changes
@mkalinin
Copy link
Contributor

mkalinin commented Mar 17, 2022

We also probably need a "meta" section mapping forks to a set of methods. That is, Bellatrix uses all V1, whereas Capella uses a mix.

Good point. If kept in the same file it could become a mess after a few forks that are affecting Engine API. Probably it worth having a file per fork as we used to have in consensus specs. In this case we may want to rename specification.md to paris.md, capella.md will then be an extension to Paris. Also, I guess methods from ancient forks that are currently unused may be marked as deprecated, this could be described in a section of related fork_name.md file.

@lightclient lightclient added the A-engine Area: for future consideration label May 19, 2022
marioevz
marioevz reviewed Sep 20, 2022
View reviewed changes
@ralexstokes ralexstokes force-pushed the add-withdrawal-operations branch from 6a785aa to fa90a90 Compare September 21, 2022 10:34
ralexstokes
ralexstokes commented Sep 21, 2022
View reviewed changes
lightclient
lightclient reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note about how to deal with null vs. [] values for withdrawals field.

@ethDreamer ethDreamer mentioned this pull request Oct 6, 2022
Closed
@ralexstokes ralexstokes mentioned this pull request Nov 2, 2022
Closed
terencechain
terencechain reviewed Nov 2, 2022
View reviewed changes
lightclient
lightclient reviewed Nov 3, 2022
View reviewed changes
g11tech
g11tech approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ralexstokes ralexstokes merged commit f33432b into ethereum:main Nov 3, 2022
@ralexstokes ralexstokes deleted the add-withdrawal-operations branch November 3, 2022 20:08
@g11tech g11tech mentioned this pull request Nov 3, 2022
Merged
@lightclient lightclient mentioned this pull request Nov 5, 2022
Closed
This was referenced Nov 11, 2022
Merged
Merged
@yperbasis yperbasis mentioned this pull request Nov 30, 2022
Merged
yperbasis added a commit to ledgerwatch/erigon-lib that referenced this pull request Dec 1, 2022
@yperbasis
Add withdrawal operations to Engine API (#734)
f32d654 
See ethereum/execution-apis#195

Prerequisite: erigontech/interfaces#134
yperbasis added a commit to erigontech/erigon that referenced this pull request Dec 1, 2022
@yperbasis
Withdrawals part 1 (#6009)
d82c778 
This PR partially implements
[EIP-4895](https://eips.ethereum.org/EIPS/eip-4895): Beacon chain push
withdrawals as operations. The new Engine API methods
(ethereum/execution-apis#195) are implemented.

_Body downloader and saving withdrawals into DB are not implemented
yet!_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkalinin mkalinin mkalinin left review comments

@lightclient lightclient lightclient left review comments

+4 more reviewers

@djrtwo djrtwo djrtwo left review comments

@marioevz marioevz marioevz left review comments

@terencechain terencechain terencechain left review comments

@g11tech g11tech g11tech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-engine Area: for future consideration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ralexstokes @mkalinin @djrtwo @marioevz @lightclient @terencechain @g11tech